andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double
rather than Double to avoid NPE
URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r377223058
##########
File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java
##########
@@ -93,16 +99,13 @@ public double getMax() {
if (values.isEmpty()) {
return 0;
}
- Double res = null;
+ double res = 0;
for (Update u : values.values()) {
if (!(u.value instanceof Number)) {
+ log.warn("not a Number: " + u.value);
Review comment:
Note I'm not completely clear whether `u.value` is ever _expected_ to not be
a `Number` - have seen this line report `false` and `LocalStatsCache` and I'm
tracing back through to find out why these occur.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
