[ https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037788#comment-17037788 ]
Tomoko Uchida commented on LUCENE-9201: --------------------------------------- [~dweiss] Thank you for your guidance and detailed comments in the patch! I applied this [^LUCENE-9201-ecj.patch] to my branch and ran the {{ecjLint}} task, then found the task seemed to finish in one second without executing the ECJ's Main class. (I intentionally added an unused import to o.a.l.a.Analyzer but that wasn't detected.) {code:java} $ ./gradlew :lucene:core:ecjLint BUILD SUCCESSFUL in 1s 4 actionable tasks: 4 up-to-date {code} I have not found any problems in the task definition (and not yet studied deeply how it works), but am I missing something? With my previous patch [https://github.com/apache/lucene-solr/pull/1242/files], for example, the {{:lucene:core:ecjLint}} takes about five seconds and (correctly) fails with this failure message if there are unused imports. {code:java} $ ./gradlew :lucene:core:ecjLint > Task :lucene:core:ecjLint ---------- 1. ERROR in /mnt/hdd/repo/lucene-solr-mirror/lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java (at line 27) import java.util.ArrayList; ^^^^^^^^^^^^^^^^^^^ The import java.util.ArrayList is never used ---------- 1 problem (1 error) > Task :lucene:core:ecjLint FAILED FAILURE: Build failed with an exception. * Where: Script '/mnt/hdd/repo/lucene-solr-mirror/gradle/validation/documentation-lint.gradle' line: 130 * What went wrong: Execution failed for task ':lucene:core:ecjLint'. > Process 'command '/usr/local/java/adoptopenjdk/jdk-11.0.3+7/bin/java'' > finished with non-zero exit value 255 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 4s {code} I will look a bit more closely at why the ecjLint task doesn't work for me... > Port documentation-lint task to Gradle build > -------------------------------------------- > > Key: LUCENE-9201 > URL: https://issues.apache.org/jira/browse/LUCENE-9201 > Project: Lucene - Core > Issue Type: Sub-task > Affects Versions: master (9.0) > Reporter: Tomoko Uchida > Assignee: Tomoko Uchida > Priority: Major > Attachments: LUCENE-9201-ecj.patch, javadocGRADLE.png, > javadocHTML4.png, javadocHTML5.png > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Ant build's "documentation-lint" target consists of those two sub targets. > * "-ecj-javadoc-lint" (Javadoc linting by ECJ) > * "-documentation-lint"(Missing javadocs / broken links check by python > scripts) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org