[
https://issues.apache.org/jira/browse/LUCENE-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052040#comment-17052040
]
Bruno Roustant commented on LUCENE-9257:
----------------------------------------
New PR#1320 which removes FSTLoadMode and *also* Reader attributes.
When removing FSTLoadMode I realized that Reader attributes have been
introduced for it and they now become unused. Since Reader attributes represent
a lot of code I think it is interesting to remove it. If sometime in the future
someone needs to get them back, this is commit
a302be381ea611e57d32d7f277206e726329fa6e.
Please tell me if it is ok to remove Reader attributes, or if we should keep
them (but in this case, where do we define the attribute key constant?).
> FSTLoadMode should not be BlockTree specific as it is used more generally in
> index package
> ------------------------------------------------------------------------------------------
>
> Key: LUCENE-9257
> URL: https://issues.apache.org/jira/browse/LUCENE-9257
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Bruno Roustant
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> FSTLoadMode and its associate attribute key (static String) are currently
> defined in BlockTreeTermsReader, but they are actually used outside of
> BlockTree in the general "index" package.
> CheckIndex and ReadersAndUpdates are using these enum and attribute key to
> drive the FST load mode through the SegmentReader which is not specific to a
> postings format. They have an unnecessary dependency to BlockTreeTermsReader.
> We could move FSTLoadMode out of BlockTreeTermsReader, to make it a public
> enum of the "index" package. That way CheckIndex and ReadersAndUpdates do not
> import anymore BlockTreeTermsReader.
> This would also allow other postings formats to use the same enum (e.g.
> LUCENE-9254)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
