mikemccand commented on a change in pull request #1319: LUCENE-9164: process all events before closing gracefully URL: https://github.com/apache/lucene-solr/pull/1319#discussion_r389313897
########## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ########## @@ -299,7 +300,77 @@ static int getActualMaxDocs() { final FieldNumbers globalFieldNumberMap; final DocumentsWriter docWriter; - private final Queue<Event> eventQueue = new ConcurrentLinkedQueue<>(); + private final EventQueue eventQueue = new EventQueue(this); + + static final class EventQueue implements Closeable { + private volatile boolean closed = false; Review comment: No need to i it with `false` ... this is already the default for Java. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org