jpountz commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r390522773
########## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ########## @@ -933,6 +932,13 @@ public Executor getExecutor() { return executor; } + /** + * Returns this searchers slice execution control plane or <code>null</code> if no executor was provided + */ + public SliceExecutor getSliceExecutor() { Review comment: we shouldn't make this method public if it returns a pkg-private class, let's make the method pkg-private too? Or even remove it entirely as I'm not seeing any call site for it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org