jpountz commented on a change in pull request #1294: LUCENE-9074: Slice
Allocation Control Plane For Concurrent Searches
URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r388497511
##########
File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
##########
@@ -662,34 +676,19 @@ public TopFieldDocs reduce(Collection<TopFieldCollector>
collectors) throws IOEx
}
query = rewrite(query);
final Weight weight = createWeight(query, scoreMode, 1);
- final List<Future<C>> topDocsFutures = new
ArrayList<>(leafSlices.length);
- for (int i = 0; i < leafSlices.length - 1; ++i) {
+ final List<FutureTask> listTasks = new ArrayList<>();
Review comment:
Let's avoid introducing warnings about generics, FutureTask needs to be
parameterized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
