[ 
https://issues.apache.org/jira/browse/LUCENE-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057386#comment-17057386
 ] 

ASF subversion and git services commented on LUCENE-8849:
---------------------------------------------------------

Commit 2144a46e958250bf8c6e838ed636aeab64318ae4 in lucene-solr's branch 
refs/heads/branch_8x from Michele Palmia
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2144a46 ]

LUCENE-8849: DocValuesRewriteMethod.visit should visit subquery

(cherry picked from commit 5286098ac5c2f6bd69ba7b9c9c48343bc1a59ea9)


> DocValuesRewriteMethod.visit should visit the MTQ
> -------------------------------------------------
>
>                 Key: LUCENE-8849
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8849
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-8849.patch
>
>
> The DocValuesRewriteMethod implements the QueryVisitor API (visit method) in 
> a way that surprises me.  It does not visit the wrapped MTQ query.  Shouldn't 
> it?  Here is what I think it should do, similar to other query wrappers:
> {code:java}
>     @Override
>     public void visit(QueryVisitor visitor) {
>       query.visit(visitor.getSubVisitor(BooleanClause.Occur.MUST, this));
>     }
> {code}
> CC [~romseygeek]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to