jimczi commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#issuecomment-598150417 Thanks for the ping @msokolov . > if you can comment on whether the MaxScoreAccumulator still provides additional benefit alongside this opto? I haven't tried removing it, but I wonder if it might be doing something redundant now - I'm not totally clear what impact setMinCompetitiveScore will have. It's redundant in spirit but the MaxScoreAccumulator is for queries sorted by relevancy. So it used so that queries sorted by relevancy can use `setMinCompetitiveScore` even if they have a tiebreaker on another field (using TopFieldCollector). The logic is similar to what you added in the `MaxScoreTerminator` except that the side effects of changes in the maximum score are handled by the top collectors directly. I left a comment in the original issue but I think we should try to merge the optimization you have for the sorted index case in the current logic or create a new top field collector dedicated to optimize the retrieval of large top N on sorted indices. With this pr we would have 3 different objects used by concurrent requests to speed up search but I think it would be preferrable to specialize at this point. What do you think ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
