msokolov commented on issue #1316: LUCENE-8929 parallel early termination in TopFieldCollector using minmin score URL: https://github.com/apache/lucene-solr/pull/1316#issuecomment-597359816 I've done pretty extensive performance testing, results are good, and unit tests are passing, but I would really appreciate some eyeballs if anyone has the time because this is a pretty sensitive area, and the implementation I've tested extensively in the wild is not exactly the same as this one, although it implements the same strategy. I'm also particularly interested, @jimczi, if you can comment on whether the `MaxScoreAccumulator` still provides additional benefit alongside this opto? I haven't tried removing it, but I wonder if it might be doing something redundant now - I'm not totally clear what impact setMinCompetitiveScore will have.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
