munendrasn commented on a change in pull request #1334: SOLR-8306: Enhance
ExpandComponent to allow expand.hits=0
URL: https://github.com/apache/lucene-solr/pull/1334#discussion_r392043916
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java
##########
@@ -668,6 +676,18 @@ public void collect(int docId) throws IOException {
}
+ private static Collector getExpandCollector(int limit, Sort sort) throws
IOException {
Review comment:
I think this method should be part of `GroupCollector` (default
implementation) and method name could simply be `getCollector`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
