[
https://issues.apache.org/jira/browse/LUCENE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059738#comment-17059738
]
Munendra S N edited comment on LUCENE-8103 at 3/15/20, 5:19 PM:
----------------------------------------------------------------
This also contains change were {{objectValue(doc)}} calls {{floatValue(doc)}}
which returns default value if {{exists(doc)}} returns {{false}} but previously
{{objectValue(doc)}} used to return {{null}} exists returned false even if
default value is specified (in pure lucene case, there will always be default
value). If this is expected change/fix should we document the change in
behavior?
Above change resolves LUCENE-8908. Also, I wanted to share this
[comment|https://issues.apache.org/jira/browse/LUCENE-8908?focusedCommentId=16887518&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16887518]
which is from Solr's perspective as {{query}} could be used even without
default value.
Just sharing my thoughts, please free to ignore if it doesn't apply here
was (Author: munendrasn):
This also contains change were {{objectValue(doc)}} calls {{floatValue(doc)}}
which returns default value if {{exists(doc)}} returns {{false}} but previously
{{objectValue(doc)}} used to return {{null}} exists returned false even if
default value is specified (in pure lucene case, there will always be default
value). If this is expected change/fix should we document the change is
behavior?
This also resolves LUCENE-8908. Also, I wanted to share this
[comment|https://issues.apache.org/jira/browse/LUCENE-8908?focusedCommentId=16887518&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16887518]
which is from Solr's perspective as {{query}} could be used even without
default value.
Just sharing my thoughts, please free to ignore if it doesn't apply here
> QueryValueSource should use TwoPhaseIterator
> --------------------------------------------
>
> Key: LUCENE-8103
> URL: https://issues.apache.org/jira/browse/LUCENE-8103
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/other
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 8.6
>
> Attachments: LUCENE-8103.patch, LUCENE-8103.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> QueryValueSource (in "queries" module) is a ValueSource representation of a
> Query; the score is the value. It ought to try to use a TwoPhaseIterator
> from the query if it can be offered. This will prevent possibly expensive
> advancing beyond documents that we aren't interested in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
