[
https://issues.apache.org/jira/browse/SOLR-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060387#comment-17060387
]
Lucene/Solr QA commented on SOLR-10157:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 76m 46s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 85m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.api.collections.TestHdfsCloudBackupRestore |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-10157 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12996771/SOLR-10157.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-170-generic #199-Ubuntu SMP
Thu Nov 14 01:45:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 6ae69d3 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | LTS |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/715/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/715/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/715/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> JSON Facets should give more helpful error msg when users attempt to an
> unknown aggregation
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-10157
> URL: https://issues.apache.org/jira/browse/SOLR-10157
> Project: Solr
> Issue Type: Improvement
> Components: Facet Module
> Reporter: Chris M. Hostetter
> Assignee: Munendra S N
> Priority: Major
> Attachments: SOLR-10157.patch, SOLR-10157.patch
>
>
> Sample question from a confused solr-user email...
> {noformat}
> > I'm getting this error when I tried to do a division in JSON Facet.
> >
> > "error":{
> > "msg":"org.apache.solr.search.SyntaxError: Unknown aggregation agg_div
> > in ('div(4,2)', pos=4)",
> > "code":400}}
> >
> >
> > Is this division function supported in JSON Facet?
> {noformat}
> And the subsequent followup from the same user...
> bq. I found that we can't put div(4,2) directly, as it wouldn't work.
> bq. It will work if I put something like max(div(4,2)).
> ----
> It seems like a better error handline code path for
> {{FunctionQParser.parseAgg}} (once we've confirmed no such aggregation
> exists) would be:
> * attempt to parse the original string as a regular (non-Agg)ValueSource)
> function
> ** if that succeeds, give the user an error indicating that this ValueSource
> must be wrapped in an aggregation
> ** if it fails, continue to throw the original error
> * either way, any error thrown should refer to the _original_ {{id}} before
> For example:
> * {{div(price,popularity)}} should throw an error with a msg along the lines
> of: {{'div' is a per-document function, not a multi-document aggregation
> function, input: div(price,popularity)}}
> * {{HOSS(price,popularity)}} on the other hand should throw an error such
> as: {{Unknown aggregation HOSS in ('HOSS(price,populaity)' ...}}
> ** note the message cites {{HOSS}} not {{agg_HOSS}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
