mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394707206
########## File path: solr/core/src/java/org/apache/solr/store/blob/metadata/ServerSideMetadata.java ########## @@ -212,9 +212,12 @@ public long getGeneration() { } /** - * @return Null if the directory hash was not computed for the given Core + * @throw IllegalStateException is this instance was not created with a computed directoryHash Review comment: Actually I don't see this method being used any where. It'll be better to delete the method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org