cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401067383
########## File path: solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java ########## @@ -228,12 +226,8 @@ private void searchWithTimeLimiter(Query query, collector = MultiCollector.wrap(collector, hitCountCollector); } - if (filter.filter != null) { - query = new BooleanQuery.Builder() - .add(query, Occur.MUST) - .add(filter.filter, Occur.FILTER) - .build(); - } + query = QueryUtils.combineQueryAndFilter(query, filter.filter); Review comment: Thanks for the pointer, i see the `MatchNoDocsQuery` now in SolrFeature, hadn't looked before. Outside of `ltr/SolrFeature` though the `QueryUtils.combineQueryAndFilter` is using `MatchAllDocsQuery`, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org