[ https://issues.apache.org/jira/browse/LUCENE-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072612#comment-17072612 ]
Stamatis Zampetakis commented on LUCENE-9299: --------------------------------------------- Looking in [HowToContribute|https://cwiki.apache.org/confluence/display/LUCENE/HowToContribute]I thought that the patch approach was the nominal way for contributing to the project. Out of curiosity is there another page more up to date? I will open a PR no problem. I don't completely follow your remark. Currently if maxClauseCount is set to 1024 and a query (as the one provided in the unit test) has 1025 clauses the visitor will not throw TooManyClauses exception. Is this expected? > ClausesCheckVisitor fails to throw TooManyClauses exception when the clauses > in a query exceeds the limit by 1 > -------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-9299 > URL: https://issues.apache.org/jira/browse/LUCENE-9299 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: master (9.0) > Reporter: Stamatis Zampetakis > Priority: Trivial > Attachments: LUCENE-9299.patch > > > The visitor that was introduced in LUCENE-8811 (obtained by > IndexSearcher#getNumClausesCheckVisitor) that checks that the number of > clauses in query does not exceed a certain limit (defined by > org.apache.lucene.search.IndexSearcher#setMaxClauseCount) misses the case > where the clauses/terms in the query exceed the limit by one. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org