dweiss commented on a change in pull request #1416: LUCENE-9286:
FST.Arc.BitTable is read directly from the FST bytes.
URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405421327
##########
File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java
##########
@@ -195,10 +209,9 @@
posArcsStart = other.posArcsStart();
arcIdx = other.arcIdx();
numArcs = other.numArcs();
- if (nodeFlags() == ARCS_FOR_DIRECT_ADDRESSING) {
- bitTable = other.bitTable() == null ? null : other.bitTable().copy();
- firstLabel = other.firstLabel();
- }
+ bitTableStart = other.bitTableStart;
Review comment:
I don't see the full code in the diff but I believe all fields should be
copied (or cleared, depending on the condition) from other. It may be a bit of
an overhead but it'd keep internal state of arcs consistent (and debugging
easier). I recall this code was copying just the required fields depending on
nodeFlags() - it should clear or copy everything, really.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
