mikemccand commented on a change in pull request #1418: LUCENE-9309: Wait for #addIndexes merges when aborting merges URL: https://github.com/apache/lucene-solr/pull/1418#discussion_r406464525
########## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ########## @@ -397,11 +393,12 @@ int availablePermits() { HashSet<SegmentCommitInfo> mergingSegments = new HashSet<>(); private final MergeScheduler mergeScheduler; + private Set<SegmentMerger> runningAddIndexesMerges = new HashSet<>(); private LinkedList<MergePolicy.OneMerge> pendingMerges = new LinkedList<>(); private Set<MergePolicy.OneMerge> runningMerges = new HashSet<>(); private List<MergePolicy.OneMerge> mergeExceptions = new ArrayList<>(); private long mergeGen; - private boolean stopMerges; + private boolean stopMerges; // TODOD make sure this is only changed once and never set back to false Review comment: Remove extra `D`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org