[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084428#comment-17084428
]
Erick Erickson commented on LUCENE-7788:
----------------------------------------
Why? What's the advantage of having yet another idiom that is sometimes one way
and sometimes another? We have far too many nooks and crannies in Solr that are
opaque, I'm reluctant to add yet another one.
And note that adding I'm proposing adding the "if" clause _only_ if the
logging message contains a method call, or can't be rewritten to avoid the
string concatenation. I'm not proposing wrapping every logging call in an if
clause.
Plus, the number of INFO level logging calls completely dominates finer-grained
calls. It's perfectly reasonable to run at WARN level and expect that the WARN
messages are something that you should pay attention to and can turn on INFO
when needed.
The entire discussion about whether we should look at the thousands of logging
calls and figure out which ones should be at a different level is another
topic, maybe SOLR-11934
> fail precommit on unparameterised log messages and examine for wasted
> work/objects
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
