madrob commented on a change in pull request #1432: SOLR-14404 CoreContainer
level custom requesthandlers
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r409691926
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpSolrClient.java
##########
@@ -62,6 +63,9 @@ public static RemoteExecutionException create(String host,
NamedList errResponse
if (errObj != null) {
Number code = (Number) getObjectByPath(errObj, true,
Collections.singletonList("code"));
String msg = (String) getObjectByPath(errObj, true,
Collections.singletonList("msg"));
+ if(msg == null) msg = "";
Review comment:
There's already a null check later, what kinds of messages do we get here
that are useful and don't leak too much internals?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
