[ https://issues.apache.org/jira/browse/SOLR-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089964#comment-17089964 ]
David Smiley commented on SOLR-8394: ------------------------------------ Looks pretty good, but I'd like to see you improve the code slightly so as to remove the duplicate logic – you return multiple times -1. Notice that FilterLeafReader.unwrap takes _any_ leafReader, and so you needn't check if it's a FilterLeafReader to begin with. Also you should perhaps do this in a loop. Can you mention in what real-world circumstance this happens? > Luke handler doesn't support FilterLeafReader > --------------------------------------------- > > Key: SOLR-8394 > URL: https://issues.apache.org/jira/browse/SOLR-8394 > Project: Solr > Issue Type: Improvement > Reporter: Steve Molloy > Priority: Major > Attachments: SOLR-8394.patch, SOLR-8394.patch, SOLR-8394.patch > > > When fetching index information, luke handler only looks at ramBytesUsed for > SegmentReader leaves. If these readers are wrapped in FilterLeafReader, no > RAM usage is returned. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org