[
https://issues.apache.org/jira/browse/SOLR-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090250#comment-17090250
]
David Smiley commented on SOLR-12690:
-------------------------------------
[~erickerickson] looks like you goofed in SolrShardReporter line 66, which is
NOT a log statement. CC [~ab] this has to do with metrics
> Regularize LoggerFactory declarations
> -------------------------------------
>
> Key: SOLR-12690
> URL: https://issues.apache.org/jira/browse/SOLR-12690
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 7.5, 8.0
>
> Attachments: SOLR-12690.patch, SOLR-12690.patch
>
>
> LoggerFactory declarations have several different forms, they should all be:
> private static final Logger log =
> LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
> * lowercase log
> * private static
> * non hard-coded class lookup.
> I'm going to regularize all of these, I think there are about 80 currently,
> we've been nibbling away at this but I'll try to do it in one go.
> [~cpoerschke] I think there's another Jira about this that I can't find just
> now, ring any bells?
> Once that's done, is there a good way to make violations of this fail
> precommit?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
