[ 
https://issues.apache.org/jira/browse/LUCENE-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091483#comment-17091483
 ] 

ASF subversion and git services commented on LUCENE-9340:
---------------------------------------------------------

Commit 72888bced33ff6c85102b162ff2a7303a17e253f in lucene-solr's branch 
refs/heads/branch_8x from Alan Woodward
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=72888bc ]

LUCENE-9340: Deprecate SimpleBindings#add(SortField) (#1447)

This method is trappy; it doesn't work for all SortField types, but doesn't tell
you that until runtime. This commit deprecates it, and removes all other
callsites in the codebase.


> Deprecate and remove the SimpleBindings.add(SortField) method
> -------------------------------------------------------------
>
>                 Key: LUCENE-9340
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9340
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This method is trappy, in that it only works for certain types of SortField 
> and you only find out which at runtime.  We should deprecate it and encourage 
> users to pass an equivalent DoubleValuesSource instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to