[ 
https://issues.apache.org/jira/browse/SOLR-14472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108508#comment-17108508
 ] 

David Smiley commented on SOLR-14472:
-------------------------------------

I think I'll commit this Monday.  In the CHANGES.txt I can convey this as an 
optimization, and mention it counts all cores.

> Autoscaling "cores" preference should count all cores, not just loaded.
> -----------------------------------------------------------------------
>
>                 Key: SOLR-14472
>                 URL: https://issues.apache.org/jira/browse/SOLR-14472
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>
> The AutoScaling "cores" preference works by counting the core names that are 
> retrievable via the metrics API.  99% of the time, that's fine but it does 
> not count unloaded transient cores that are also tracked by the 
> CoreContainer, which I think should be counted as well.  Most users don't 
> have such cores so it won't affect them.
> Furthermore, instead of counting them by asking the metrics API to return 
> each loaded core name, it should use the {{CONTAINER.cores}} prefix set of 
> counters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to