janhoy commented on a change in pull request #1403:
URL: https://github.com/apache/lucene-solr/pull/1403#discussion_r426598653
##########
File path:
solr/core/src/test/org/apache/solr/security/BasicAuthOnSingleNodeTest.java
##########
@@ -45,13 +45,13 @@ public void setupCluster() throws Exception {
.setBasicAuthCredentials("solr", "solr")
.process(cluster.getSolrClient());
cluster.waitForActiveCollection(COLLECTION, 4, 4);
+ }
- JettySolrRunner jetty = cluster.getJettySolrRunner(0);
Review comment:
I removed this part of initialization - don't see why we should tear
down and recreate cluster every time?
##########
File path:
solr/core/src/test/org/apache/solr/security/BasicAuthOnSingleNodeTest.java
##########
@@ -45,13 +45,13 @@ public void setupCluster() throws Exception {
.setBasicAuthCredentials("solr", "solr")
.process(cluster.getSolrClient());
cluster.waitForActiveCollection(COLLECTION, 4, 4);
+ }
- JettySolrRunner jetty = cluster.getJettySolrRunner(0);
- jetty.stop();
- cluster.waitForJettyToStop(jetty);
- jetty.start();
- cluster.waitForAllNodes(30);
- cluster.waitForActiveCollection(COLLECTION, 4, 4);
+ @Override
+ @After
+ public void tearDown() throws Exception {
+ cluster.shutdown();
Review comment:
With just one test in this class, resource cleanup happened
automatically at the end I guess, but with two methods, we need to shutdown
cluster in `tearDown`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
