[ 
https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111446#comment-17111446
 ] 

David Smiley commented on SOLR-14484:
-------------------------------------

I propose simply using {{String.valueOf(client.getBaseURL())}} instead, and 
thus wind up with a simple "null" string in this case.  WDYT?

> NPE in ConcurrentUpdateHttp2SolrClient MDC logging
> --------------------------------------------------
>
>                 Key: SOLR-14484
>                 URL: https://issues.apache.org/jira/browse/SOLR-14484
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 8.4.1
>            Reporter: Andras Salamon
>            Priority: Minor
>         Attachments: SOLR-14484-01.patch
>
>
> {{client.getBaseURL()}} can be null in {{ConcurrentUpdateHttp2SolrClient}} 
> which can cause problems in MDC logging.
> We had the following error in the stacktrace. We were using Solr 8.4.1 from 
> lily hbase-indexer which still uses log4j 1.2:
> {noformat}
> Error from server at http://127.0.0.1:45895/solr/collection1: 
> java.lang.NullPointerException
>  at java.util.Hashtable.put(Hashtable.java:459)
>  at org.apache.log4j.MDC.put0(MDC.java:150)
>  at org.apache.log4j.MDC.put(MDC.java:85)
>  at org.slf4j.impl.Log4jMDCAdapter.put(Log4jMDCAdapter.java:67)
>  at org.slf4j.MDC.put(MDC.java:147)
>  at 
> org.apache.solr.client.solrj.impl.ConcurrentUpdateHttp2SolrClient.addRunner(ConcurrentUpdateHttp2SolrClient.java:346)
>  at 
> org.apache.solr.client.solrj.impl.ConcurrentUpdateHttp2SolrClient.waitForEmptyQueue(ConcurrentUpdateHttp2SolrClient.java:565)
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to