[
https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121063#comment-17121063
]
Erick Erickson commented on LUCENE-9382:
----------------------------------------
[~dweiss] Your changes look good to me. I haven't a clue why switches would
barf. Am I correct that this change makes the script work and there's nothing
for me to do except say thanks?
There are ~40 un-commented logging calls in Lucene, all in lucene/luke, as well
as some commented-out logging calls elsewhere. I dithered over whether to
include Lucene or not. On the one hand the logging calls in the Luke module are
entirely irrelevant to the intent of looking at inefficiencies in the use of
logging messages, Luke doesn't count in that respect. OTOH, it adds maybe 2-3
seconds to the check.
I'd have no objection to restricting the check to Solr. David Smiley also had
the same question FWIW.
What probably makes the most sense for Lucene is to either would be a
different check, one that just failed on _any_ logging call except in Luke. Or
just not checking at all given the dearth of real calls.
> Lucene's gradle version can't cope with Java 14
> -----------------------------------------------
>
> Key: LUCENE-9382
> URL: https://issues.apache.org/jira/browse/LUCENE-9382
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Alan Woodward
> Assignee: Dawid Weiss
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If you have JDK 14 installed as your default java, then attempting to use
> gradle within the lucene-solr project can result in errors, particularly if
> you have other projects that use more recent gradle versions on the same
> machine.
> ```
> java.lang.NoClassDefFoundError: Could not initialize class
> org.codehaus.groovy.vmplugin.v7.Java7
> at
> org.codehaus.groovy.vmplugin.VMPluginFactory.<clinit>(VMPluginFactory.java:43)
> at
> org.codehaus.groovy.reflection.GroovyClassValueFactory.<clinit>(GroovyClassValueFactory.java:35)
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
