[ 
https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-14520:
--------------------------------------
    Attachment: SOLR-14520.patch
        Status: Open  (was: Open)

Attaching an updated patch:
 * small correction to the "expected" results in TestJsonFacetRefinement
 * fix proposed by [~mgibney] in his "[^SOLR-14467_allBuckets_refine.patch]" 
attachment to SOLR-14467 (where this bug was first found).

I still need to review & think about michael's solution a bit more before 
commiting – my initial impression is that it's better then what we have now, 
but i want to think through if it introduces any diff/new bugs.
----
Michael: one concern i have that's still nagging me is how to reproduce the 2nd 
type of failure i mentioned above – i believe it's also intrinsicly "fixed" in 
your patch by the nature of changing out hte {{countAcc}} to something that 
will just flat out ignore the slot, but i'm still perplexed why my attempts at 
updating the tests to isolate it couldn't seem to trigger it – do you have any 
idea what a simple reproducible test case for that failure might look like?

> json.facets: allBucket:true can cause server errors when combined with 
> refine:true
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-14520
>                 URL: https://issues.apache.org/jira/browse/SOLR-14520
>             Project: Solr
>          Issue Type: Bug
>          Components: Facet Module
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-14520.patch, SOLR-14520.patch
>
>
> Another bug that was discovered while testing SOLR-14467...
> In some situations, using {{allBuckets:true}} in conjunction with 
> {{refine:true}} can cause server errors during the "refinement" requests to 
> the individual shards -- either NullPointerExceptions from some (nested) 
> SlotAccs when SpecialSlotAcc tries to collect them, or 
> ArrayIndexOutOfBoundsException from CountSlotArrAcc.incrementCount because 
> it's asked to collect to "large" slot# values even though it's been 
> initialized with a size of '1'
> NOTE: these problems may be specific to FacetFieldProcessorByArrayDV - i have 
> not yet seen similar failures from FacetFieldProcessorByArrayUIF (those are 
> the only 2 used when doing refinement) but that may just be a fluke of 
> testing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to