murblanc opened a new pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561


   # Description
   
   Make sure Collection API tasks are processed in enqueue order by the 
Overseer and OverseerCollectionMessageHandler
   
   # Solution
   
   The LockTree.Session class already existed to address that need but there 
were a few missing pieces preventing it from doing so. Added these pieces.
   
   # Tests
   
   A previously failing test MultiThreadedOCPTest (SOLR-14524) no longer fails. 
Also ran local massive enqueue tests into Collection API ZK queue and 
instrumented OverseerTaskProcessor to verify dequeue is in order (requires 
heavy handed code hacks so this was only run locally to help diagnose and 
verify).
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to