[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141911#comment-17141911 ]
Ilan Ginzburg commented on SOLR-14579: -------------------------------------- I second [~ab] here. When we write non obvious code, we should comment it so the next person understands the intention. Your explanation [~noble.paul] is perfect! it belongs in the code. > Remove SolrJ 'Utils' generic map functions > ------------------------------------------ > > Key: SOLR-14579 > URL: https://issues.apache.org/jira/browse/SOLR-14579 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: master (9.0) > Reporter: Megan Carey > Assignee: Noble Paul > Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Remove the map functions like `NEW_HASHMAP_FUN` from the Utils class in solrj > module to reduce warnings and improve code quality. > [https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Utils.java#L92] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org