atris commented on a change in pull request #1606:
URL: https://github.com/apache/lucene-solr/pull/1606#discussion_r444750302
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1164,6 +1171,16 @@ private SolrCoreMetricManager
initCoreMetricManager(SolrConfig config) {
return coreMetricManager;
}
+ private CircuitBreakerManager initCircuitBreakerManager() {
+ CircuitBreakerManager circuitBreakerManager = new CircuitBreakerManager();
+
+ // Install the default circuit breakers
+ CircuitBreaker memoryCircuitBreaker = new MemoryCircuitBreaker(this);
+ circuitBreakerManager.registerCircuitBreaker(CircuitBreakerType.MEMORY,
memoryCircuitBreaker);
Review comment:
Agreed. I have moved this to a method in CircuitBreakerManager that can
be delegated to for handling this scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
