[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144561#comment-17144561
]
Noble Paul commented on SOLR-14576:
-----------------------------------
{quote}Using String as a key in an Identity HashMap seems dubious, but probably
not any more dubious than the SolrCore itself.
{quote}
True [~mdrob]. That's m concern as well. JVMs intern the Strings and there is a
very good chance that the Object lingers on. I think we should have a {{new
Object()}} inside {{SolrCore}} and use that as a key to avoid that problem
> HttpCacheHeaderUti.etagCoreCache should not use a SolrCore as key
> -----------------------------------------------------------------
>
> Key: SOLR-14576
> URL: https://issues.apache.org/jira/browse/SOLR-14576
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Noble Paul
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> GC performance is affected when the key is a complex data structure. We can
> make it
> {code}
> private static WeakIdentityMap<String, EtagCacheVal> etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
> instead of
> {code}
> private static WeakIdentityMap<SolrCore, EtagCacheVal> etagCoreCache =
> WeakIdentityMap.newConcurrentHashMap();
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
