s1monw commented on a change in pull request #1617:
URL: https://github.com/apache/lucene-solr/pull/1617#discussion_r446379945
##########
File path: lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
##########
@@ -399,6 +416,40 @@ boolean hasFinished() {
Optional<Boolean> hasCompletedSuccessfully() {
return Optional.ofNullable(mergeCompleted.getNow(null));
}
+
+
+ /**
+ * Called before the merge is committed
+ */
+ void onMergeCommit() {
+ }
+
+ /**
+ * Sets the merge readers for this merge.
+ */
+ void initMergeReaders(IOUtils.IOFunction<SegmentCommitInfo, MergeReader>
readerFactory) throws IOException {
+ assert mergeReaders.isEmpty() : "merge readers must be empty";
+ assert mergeCompleted.isDone() == false : "merge is already done";
+ ArrayList<MergeReader> readers = new ArrayList<>(segments.size());
+ try {
+ for (final SegmentCommitInfo info : segments) {
+ // Hold onto the "live" reader; we will use this to
+ // commit merged deletes
+ readers.add(readerFactory.apply(info));
+ }
+ } finally {
+ // ensure we assign this to close them in the case of an exception
+ this.mergeReaders = List.copyOf(readers);
Review comment:
I left a comment. I use immutable lists everywhere here it would be
fatal if we modify this list outside of OneMerge. I think that justifies the
copy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
