vthacker commented on a change in pull request #1620: URL: https://github.com/apache/lucene-solr/pull/1620#discussion_r446429171
########## File path: solr/core/src/java/org/apache/solr/schema/RankField.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.schema; + +import java.io.IOException; +import java.util.Map; + +import org.apache.lucene.document.FeatureField; +import org.apache.lucene.index.IndexableField; +import org.apache.lucene.index.IndexableFieldType; +import org.apache.lucene.index.Term; +import org.apache.lucene.search.Query; +import org.apache.lucene.search.SortField; +import org.apache.lucene.search.TermQuery; +import org.apache.solr.common.SolrException; +import org.apache.solr.response.TextResponseWriter; +import org.apache.solr.search.QParser; +import org.apache.solr.uninverting.UninvertingReader.Type; + +public class RankField extends FieldType { + + public static final String INTERNAL_RANK_FIELD_NAME = "_internal_rank_field"; + + @Override + public Type getUninversionType(SchemaField sf) { + throw null; + } + + @Override + public void write(TextResponseWriter writer, String name, IndexableField f) throws IOException { + } + + @Override + protected void init(IndexSchema schema, Map<String,String> args) { + super.init(schema, args); + if (schema.getFieldOrNull(INTERNAL_RANK_FIELD_NAME) != null) { + throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "A field named \"" + INTERNAL_RANK_FIELD_NAME + "\" can't be defined in the schema"); + } + for (int prop:new int[] {STORED, DOC_VALUES, OMIT_TF_POSITIONS, SORT_MISSING_FIRST, SORT_MISSING_LAST}) { + if ((trueProperties & prop) != 0) { + throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Property \"" + getPropertyName(prop) + "\" can't be set to true in RankFields"); + } + } + for (int prop:new int[] {UNINVERTIBLE, INDEXED, MULTIVALUED}) { + if ((falseProperties & prop) != 0) { + throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, "Property \"" + getPropertyName(prop) + "\" can't be set to false in RankFields"); + } + } + properties &= ~(UNINVERTIBLE | STORED | DOC_VALUES); + + } + + @Override + protected IndexableField createField(String name, String val, IndexableFieldType type) { + if (val == null || val.isEmpty()) { + return null; + } + float featureValue; + try { + featureValue = Float.parseFloat(val); + } catch (NumberFormatException nfe) { + throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "Error while creating field '" + name + "' from value '" + val + "'. Expecting float.", nfe); + } + return new FeatureField(INTERNAL_RANK_FIELD_NAME, name, featureValue); + } + + @Override + public Query getFieldQuery(QParser parser, SchemaField field, String externalVal) { Review comment: I think so? Essentially this is an exists query right? We can be safe and not support this for now? Thinking aloud on another option - What if we rewrite ( like how you have it right now ) when the value is `*` and throw an exception otherwise? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
