[ 
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149687#comment-17149687
 ] 

Mikhail Khludnev commented on SOLR-14557:
-----------------------------------------

Attached pretty straightforward fix for the grammar 
{code}
| <LPARAMS:       ("{!" ( (<_WHITESPACE>)* (~["=","}"])+ ( "=" (<QUOTED> | ("'" 
(<_SQUOTED_CHAR>)* "'") | (~[" ","}"])+ )? )? )* "}")+  (~[")"," 
","\t","\n","{","^"])* >
+| <LPARAMS_PAREN:       ("{!" ( (<_WHITESPACE>)* (~["=","}"])+ ( "=" (<QUOTED> 
| ("'" (<_SQUOTED_CHAR>)* "'") | (~[" ","}"])+ )? )? )* "}" "(")  (~[")"," 
","\t","\n","{","^"])* ")" >
 | <FILTER:        "filter(" >
 }
 
@@ -253,6 +254,7 @@ Query Clause(String field) throws SyntaxError : {
    | <LPAREN> q=Query(field) <RPAREN> [ <CARAT> boost=<NUMBER> ]
    | (<FILTER> { flags=startFilter(); } q=Query(field) <RPAREN> [ <CARAT> 
boost=<NUMBER> ] { q=getFilter(q); restoreFlags(flags); } )
    | (localParams = <LPARAMS> [ <CARAT> boost=<NUMBER> ] { 
q=getLocalParams(field, localParams.image); }  )
+   | (localParams = <LPARAMS_PAREN> [ <CARAT> boost=<NUMBER> ] { 
q=getLocalParams(field, localParams.image); }  )
{code}

Opinions? 

> eDisMax parser unable to parse {!lucene}(gigabyte)
> --------------------------------------------------
>
>                 Key: SOLR-14557
>                 URL: https://issues.apache.org/jira/browse/SOLR-14557
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>            Reporter: Mikhail Khludnev
>            Priority: Major
>              Labels: painful
>         Attachments: SOLR-14557.patch, SOLR-14557.patch, SOLR-14557.patch
>
>
> h2. Solr 4.5
> {{/select?defType=edismax&q=\{!lucene}(foo)&debugQuery=true}} 
>  
>  goes like
>  {code}
>  <str name="rawquerystring">\{!lucene}(foo)</str>
>  <str name="parsedquery_toString">content:foo</str>
>  <str name="QParser">LuceneQParser</str>
> {code}
> fine
> h2. Solr 8.2 
> with luceneMatchVersion=4.5 following SOLR-11501 I know it's a grey zone but 
> it's a question of migrating existing queries. 
> {{/select?defType=edismax&q=\{!lucene}(foo)&debugQuery=true}} 
> goes like 
> {code}
> "querystring":"\{!lucene}(foo)",
>  "parsedquery":"+DisjunctionMaxQuery(((Project.Address:lucene 
> Project.Address:foo) | (Project.OwnerType:lucene Project.OwnerType:foo) 
>  "QParser":"ExtendedDismaxQParser",
> {code}
> blah... 
> but removing braces in 8.2 works perfectly fine 
> {code}
> "querystring":"\{!lucene}foo",
>  "parsedquery":"+content:foo",
>  "parsedquery_toString":"+content:foo",
>  "QParser":"ExtendedDismaxQParser",
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to