[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150421#comment-17150421
]
Chris M. Hostetter commented on SOLR-13308:
-------------------------------------------
bq. It looks like you already did something like this, but it's specific to
RevertDefaultThreadHandlerRule. WDYT about taking that restriction away?
I don't understand the question ... what restriction are you talking about?
(are you perhaps missunderstanding the use of RuleChain? ... that doesn't
"restrict" when SystemPropertiesRestoreRule or RevertDefaultThreadHandlerRule
are used relative to eachother -- it just dictates that they will be evaluated
in a predictable order, which would be undefined if they were declared as
independent {{\@ClassRule public static TestRule ...}} variables in the same
(base) class)
Why would new BeforeClass/AfterClass methods work better then using
SystemPropertiesRestoreRule? what sitaution?
I think in general this jira can just be resolved as DONE? .... do you have any
examples/evidence of system properties leaking from one test _class_ run to
another since this change was made in f549ee353530fcd48390a314aff9ec1723b47346 ?
> Move SystemPropertiesRestoreRule to SolrTestCase
> ------------------------------------------------
>
> Key: SOLR-13308
> URL: https://issues.apache.org/jira/browse/SOLR-13308
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 8.1, master (9.0)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> [~krisden] just traced flaky HDFS tests to not clearing sysprops, see the
> discussion at SOLR-13297.
> Part of SOLR-13268 is to derive all Solr test classes from SolrTestCase.
> Once that's pushed, does it make sense to put that rule in SolrTestCase so it
> gets performed automagically so this kind of error doesn't creep back in?
> I don't know the details of how that rule is implemented or whether this
> makes sense at that level but wanted to discuss.
> I've assigned it to myself, but that's just so I don't lose track of it, but
> anyone else who wants to pick it up please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
