[
https://issues.apache.org/jira/browse/SOLR-14537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151248#comment-17151248
]
Ishan Chattopadhyaya edited comment on SOLR-14537 at 7/4/20, 8:55 AM:
----------------------------------------------------------------------
{code}
Execution failed for task ':solr:core:validateLogCalls'.
> Found 9 violations in source files (
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:98,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:98,
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:104,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:104,
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:107,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:107,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:143,
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportWriterStream.java:199,
cause: 'hasPlus: true' Suspicious logging call, Parameterize and possibly
surround with 'if (log.is*Enabled) \{..}'. Help at: 'gradlew
helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportWriterStream.java:199).
{code}
There was a line like {{log.debug("--- filler fillOutDocs in {}",
fillBuffer);}} and I converted it to {{if (log.isDebugEnabled()) log.debug("---
filler fillOutDocs in {}", fillBuffer);}}, but still no avail. I'm probably
going to remove those debug log lines for now.
was (Author: ichattopadhyaya):
{code}
Execution failed for task ':solr:core:validateLogCalls'.
> Found 9 violations in source files (
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:98,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:98,
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:104,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:104,
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:107,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:107,
cause: 'hasParens true prevLineNotIf true pernicketyLevel true' Suspicious
logging call, Parameterize and possibly surround with 'if (log.is*Enabled)
\{..}'. Help at: 'gradlew helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportBuffers.java:143,
Found an unexpected log level: isdebugenabled, file:
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportWriterStream.java:199,
cause: 'hasPlus: true' Suspicious logging call, Parameterize and possibly
surround with 'if (log.is*Enabled) \{..}'. Help at: 'gradlew
helpValidateLogCalls'
/home/ishan/code/lucene-solr/solr/core/src/java/org/apache/solr/handler/export/ExportWriterStream.java:199).
{code}
There was a line like `log.debug("--- filler fillOutDocs in {}", fillBuffer);`
and I converted it to `if (log.isDebugEnabled()) log.debug("--- filler
fillOutDocs in {}", fillBuffer);`, but still no avail. I'm probably going to
remove those debug log lines for now.
> Improve performance of ExportWriter
> -----------------------------------
>
> Key: SOLR-14537
> URL: https://issues.apache.org/jira/browse/SOLR-14537
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Export Writer
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 8.7
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Retrieving, sorting and writing out documents in {{ExportWriter}} are three
> aspects of the /export handler that can be further optimized.
> SOLR-14470 introduced some level of caching in {{StringValue}}. Further
> options for caching and speedups should be explored.
> Currently the sort/retrieve and write operations are done sequentially, but
> they could be parallelized, considering that they block on different channels
> - the first is index reading & CPU bound, the other is bound by the receiving
> end because it uses blocking IO. The sorting and retrieving of values could
> be done in parallel with the operation of writing out the current batch of
> results.
> One possible approach here would be to use "double buffering" where one
> buffered batch that is ready (already sorted and retrieved) is being written
> out, while the other batch is being prepared in a background thread, and when
> both are done the buffers are swapped. This wouldn't complicate the current
> code too much but it should instantly give up to 2x higher throughput.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
