[ https://issues.apache.org/jira/browse/SOLR-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153128#comment-17153128 ]
Lucene/Solr QA commented on SOLR-14635: --------------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 44m 13s{color} | {color:red} core in the patch failed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 48m 8s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | solr.handler.TestContainerPlugin | | | solr.util.TestCircuitBreaker | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-14635 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13007231/SOLR-14635.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene1-us-west 4.15.0-108-generic #109-Ubuntu SMP Fri Jun 19 11:33:10 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / d3f4b21deb0 | | ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 | | Default Java | LTS | | unit | https://builds.apache.org/job/PreCommit-SOLR-Build/776/artifact/out/patch-unit-solr_core.txt | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/776/testReport/ | | modules | C: solr/core U: solr/core | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/776/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > improve ThreadDumpHandler to show more info related to locks > ------------------------------------------------------------ > > Key: SOLR-14635 > URL: https://issues.apache.org/jira/browse/SOLR-14635 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Chris M. Hostetter > Assignee: Chris M. Hostetter > Priority: Major > Attachments: SOLR-14635.patch > > > Having recently spent some time trying to use ThreadDumpHandler to diagnose a > "lock leak" i realized there are quite a few bits of info available from the > ThreadMXBean/ThreadInfo datastcutures that are not included in the response, > and i think we should add them: > * switch from {{findMonitorDeadlockedThreads()}} to > {{findDeadlockedThreads()}} to also detect deadlocks from ownable > syncrhonizers (ie: ReintrantLocks) > * for each thread: > ** in addition to outputing the current {{getLockName()}} when a thread is > blocked/waiting, return info about the lock owner when available. > *** there's already dead code checking this and then throwing away the info > ** return the list of all locks (both monitors and ownable synchronizers) > held by each thread -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org