[ https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153444#comment-17153444 ]
Uwe Schindler edited comment on LUCENE-9411 at 7/8/20, 9:45 AM: ---------------------------------------------------------------- By the way: Policeman Jenkins makes statistics on all warnings since beginning of all time - here on the 8.6 branch: https://jenkins.thetaphi.de/job/Lucene-Solr-8.6-Linux/java was (Author: thetaphi): By the way: Policeman Jenkins makes statistics on all warnings since beginning of all time - here on the 8.6 branch: https://jenkins.thetaphi.de/job/Lucene-Solr-8.6-Linux/1027/java/ > Fail complation on warnings, 9x gradle-only > ------------------------------------------- > > Key: LUCENE-9411 > URL: https://issues.apache.org/jira/browse/LUCENE-9411 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Major > Labels: build > Fix For: master (9.0) > > Attachments: LUCENE-9411.patch, LUCENE-9411.patch, LUCENE-9411.patch, > LUCENE-9411.patch, annotations-warnings.patch > > > Moving this over here from SOLR-11973 since it's part of the build system and > affects Lucene as well as Solr. You might want to see the discussion there. > We have a clean compile for both Solr and Lucene, no rawtypes, unchecked, > try, etc. warnings. There are some peculiar warnings (things like > SuppressFBWarnings, i.e. FindBugs) that I'm not sure about at all, but let's > assume those are not a problem. Now I'd like to start failing the compilation > if people write new code that generates warnings. > From what I can tell, just adding the flag is easy in both the Gradle and Ant > builds. I still have to prove out that adding -Werrors does what I expect, > i.e. succeeds now and fails when I introduce warnings. > But let's assume that works. Are there objections to this idea generally? I > hope to have some data by next Monday. > FWIW, the Lucene code base had far fewer issues than Solr, but > common-build.xml is in Lucene. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org