[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153505#comment-17153505
]
Erick Erickson commented on LUCENE-9411:
----------------------------------------
I'm not sure how to balance your point .vs. building up a whole new backlog of
warnings and then have to go through a similar exercise when we require, say,
Java 14 as the minimum version.
It'd be a major pain to require devs to fix all warnings for all versions of
Java, that ain't gonna happen. And using new versions of Java is too important
to hamper by failing on error warnings.
It also would be a pain to go through parts of this exercise _again_ when we
require Java 14 b/c we'd have to go through the process of finding all the
warnings not flagged in Java 11. Admittedly the vast majority of the warnings
were rawtypes and unchecked casts, so maybe it wouldn't be as big a deal as I
fear. Or maybe the fact that I suppressed (and fixed a few) over 8,000 warnings
that had built up over years is making me worry about it too much ;)
I think what worries me is _unknowingly_ building up such a backlog again. We
could maybe ameliorate that a bit by detecting the java version and selectively
enabling/disabling the -Werror?
> Fail complation on warnings, 9x gradle-only
> -------------------------------------------
>
> Key: LUCENE-9411
> URL: https://issues.apache.org/jira/browse/LUCENE-9411
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Labels: build
> Fix For: master (9.0)
>
> Attachments: LUCENE-9411.patch, LUCENE-9411.patch, LUCENE-9411.patch,
> LUCENE-9411.patch, annotations-warnings.patch
>
>
> Moving this over here from SOLR-11973 since it's part of the build system and
> affects Lucene as well as Solr. You might want to see the discussion there.
> We have a clean compile for both Solr and Lucene, no rawtypes, unchecked,
> try, etc. warnings. There are some peculiar warnings (things like
> SuppressFBWarnings, i.e. FindBugs) that I'm not sure about at all, but let's
> assume those are not a problem. Now I'd like to start failing the compilation
> if people write new code that generates warnings.
> From what I can tell, just adding the flag is easy in both the Gradle and Ant
> builds. I still have to prove out that adding -Werrors does what I expect,
> i.e. succeeds now and fails when I introduce warnings.
> But let's assume that works. Are there objections to this idea generally? I
> hope to have some data by next Monday.
> FWIW, the Lucene code base had far fewer issues than Solr, but
> common-build.xml is in Lucene.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
