[
https://issues.apache.org/jira/browse/SOLR-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156213#comment-17156213
]
David Smiley commented on SOLR-14155:
-------------------------------------
I had a productive 1-on-1 chat with Noble on Slack, and I'm mostly through a
code-review. The underlying "how" that matters for the purpose of my above
inquiry is that the specific plugins listed in the description were modified
instead of SRL. In that sense, it's _not_ like the SRL approach of my PR that
loaded nearly all plugin types; no changes to call sites most of the time. We
don't yet agree on wether SRL is the right spot to do this, but it's on me to
present a better case for SRL once I clear it of more tech debt to thus allow a
more compelling PR (by me; different issue). When I counted plugin types in
Solr early this year, I counted 114 loaded via SRL and even more via
Class.forName. I could have been more thorough and found more, I think. The
number blew me away that it's so high, and at least to me makes it clear that
we don't want to go modify 114 call-sites to custom integrate each with the
plugin system when we could instead reasonably update SRL to do it. In the
mean time, I don't want a "great" (by my subjective opinion) to get in the way
of the "good" here.
The DirectoryFactory & UpdateLog plugin types were done here motivated by being
able to move Solr's HDFS support out of core and into a package. This
particular issue doesn't literally do that but it's a prerequisite. +1 for me
but I'll have specific by-line code comments in the PR.
The SolrEventListener plugin type was made hot-loadable and doing so
fundamentally requires some changes (SRL alone won't cut it). +1 for me but
I'll have specific by-line code comments in the PR.
The SolrCache plugin type was made to load from a package. I'd rather this be
removed from this PR (which was much more invasive than for DirectoryFactory
and UpdateLog) and await a future decision on use of SRL or whatever we come up
with at this time. So "-0" for me on this in the PR.
IMO the title was misleading; I propose "Package support: DirectoryFactory,
UpdateLog, SolrEventListener, SolrCache" (ideally removing SolrCache)
> Load all other SolrCore plugins from packages
> ---------------------------------------------
>
> Key: SOLR-14155
> URL: https://issues.apache.org/jira/browse/SOLR-14155
> Project: Solr
> Issue Type: Sub-task
> Components: packages
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Major
> Fix For: 8.7
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A few plugins configurable in {{solrconfig.xml}} still cannot be loaded from
> packages
> # DirectoryFactor
> # Updatelog
> # Cache
> # SolrEventListener (improperly implemented)
> #1 to #3 should result in reloading the core. #4 can do in-place reload
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
