[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158516#comment-17158516
]
David Smiley commented on SOLR-14636:
-------------------------------------
As the changes to Solr increase ever more in this branch ("reference_impl"),
I'm worried it will be for naught because it'll become even harder to bring
back into master. Can you bring focused changes to master branch with discrete
issues? There's probably some low hanging fruit in there (e.g.
closer-related). I know a challenge is that some of the changes, good things
in their own right, reveal problems in tests causing failures that require
further changes... and repeat such in a loop of pain. Perhaps then we need a
new branch in which many tests are ignored or fail. In a sense, you have this
branch already, "reference_impl", but there is no code review. Perhaps, when
you reach substantial success, you do extensive rebasing of your branch to
squash related changes together, to thus facilitate review and _eventually_ a
nicer history so we can see what was changed why. I encourage you to actually
not wait to do this branch rebase cleanup but to do it often. What do you or
others think? I'm basically asking you to think of the end-game. I don't want
eventually see one massive crazy commit on master. I imagine possible a
massive merge commit from another branch, even though usually we discourage
merge commits, I think it makes sense here.
> Provide a reference implementation for SolrCloud that is stable and fast.
> -------------------------------------------------------------------------
>
> Key: SOLR-14636
> URL: https://issues.apache.org/jira/browse/SOLR-14636
> Project: Solr
> Issue Type: Task
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Major
>
> SolrCloud powers critical infrastructure and needs the ability to run quickly
> with stability. This reference implementation will allow for this.
> *location*: [https://github.com/apache/lucene-solr/tree/reference_impl]
> *status*: alpha
> *speed*: ludicrous
> *tests***:
> * *core*: near {color:#00875a}*solid*{color} with
> *{color:#de350b}ignores{color}*
> * *solrj*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *test-framework*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/analysis-extras*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/analytics*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/clustering*: near {color:#00875a}*solid*{color} with
> *{color:#de350b}ignores{color}*
> * *contrib/dataimporthandler*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/dataimporthandler-extras*: near {color:#00875a}*solid*{color}
> with *{color:#de350b}ignores{color}*
> * *contrib/extraction*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/jaegertracer-configurator*: near {color:#00875a}*solid*{color}
> with {color:#de350b}*ignores*{color}
> * *contrib/langid*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/prometheus-exporter*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> * *contrib/velocity*: near {color:#00875a}*solid*{color} with
> {color:#de350b}*ignores*{color}
> _* Running tests quickly and efficiently with strict policing will more
> frequently find bugs and requires a period of hardening._
> _** Non Nightly currently, Nightly comes last._
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
