mayya-sharipova commented on a change in pull request #1610:
URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r455321149
##########
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##########
@@ -408,6 +428,7 @@ public boolean equals(Object o) {
&& other.reverse == this.reverse
&& Objects.equals(this.comparatorSource, other.comparatorSource)
&& Objects.equals(this.missingValue, other.missingValue)
+ && other.skipNonCompetitiveDocs == this.skipNonCompetitiveDocs
Review comment:
@jpountz Thank you for your feedback. Alternatively we can add
`setCanUsePoints` parameter to `Sort` object instead of `SortField`? What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
