jpountz commented on a change in pull request #1610:
URL: https://github.com/apache/lucene-solr/pull/1610#discussion_r463156089
##########
File path: lucene/core/src/java/org/apache/lucene/search/SortField.java
##########
@@ -428,7 +428,6 @@ public boolean equals(Object o) {
&& other.reverse == this.reverse
&& Objects.equals(this.comparatorSource, other.comparatorSource)
&& Objects.equals(this.missingValue, other.missingValue)
- && other.skipNonCompetitiveDocs == this.skipNonCompetitiveDocs
Review comment:
Can you add a comment to say that we're not taking it into account on
purpose? I foresee that someone will file a PR to add it after running a code
analysis tool that would complain that not all fields are taken into account
for equals otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
