[
https://issues.apache.org/jira/browse/LUCENE-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161885#comment-17161885
]
Michael McCandless commented on LUCENE-9437:
--------------------------------------------
Thanks [~goankur]. I think it makes sense to make {{decode}} public.
Thank you for improving the javadoc too.
Instead of saying {{Change the visibility to 'public'...}} can you just say
{{This method is public ...}}? I.e., future Lucene users reading this javadoc
are not particularly concerned that we had at some point changed it to public,
but rather that it *is* now public.
> Make DocValuesOrdinalsReader.decode(BytesRef, IntsRef) method publicly
> accessible
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-9437
> URL: https://issues.apache.org/jira/browse/LUCENE-9437
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 8.6
> Reporter: Ankur
> Priority: Trivial
> Attachments: LUCENE-9437.patch
>
>
> Visibility of _DocValuesOrdinalsReader.decode(BytesRef, IntsRef)_ method is
> set to 'protected'. This prevents the method from being used outside this
> class in a setting where BinaryDocValues reader is instantiated outside the
> class and binary payload containing ordinals still needs to be decoded.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
