dsmiley commented on a change in pull request #1675: URL: https://github.com/apache/lucene-solr/pull/1675#discussion_r460366284
########## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ########## @@ -1788,6 +1786,7 @@ public void unload(String name, boolean deleteIndexDir, boolean deleteDataDir, b } public void rename(String name, String toName) { + apiAssumeStandalone(); Review comment: I think it'd be more pertinent to update the Solr Ref Guide, which is what users would see. This method here is very internal. At least if a user tries it, it'll now not work with an error telling them so, as opposed to before, bad things would probably happen. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org