murblanc commented on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671219903
I could only look briefly on the phone screen (vacation) but two comments: Separating out the new lazy implementations into another PR and keeping this one for adding interfaces to internal classes would have made reviewing easier. Are there places in the code where currently the concrete classes are used and that could be changed to use the interfaces instead? In other words, how/where would these interfaces be used? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
