chatman commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472938739
##########
File path:
solr/core/src/java/org/apache/solr/cluster/events/ClusterSingleton.java
##########
@@ -0,0 +1,14 @@
+package org.apache.solr.cluster.events;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+/**
+ * Intended for {@link org.apache.solr.core.CoreContainer} plugins that should
be
+ * enabled only one instance per cluster.
+ * <p>Implementation detail: currently these plugins are instantiated on the
+ * Overseer leader, and closed when the current node loses its leadership.</p>
+ */
+@Retention(RetentionPolicy.RUNTIME)
+public @interface ClusterSingleton {
Review comment:
This level of service can be provided to plugins, but this doesn't need
to be in solr-core. This coordination can be a separate plugin outside
solr-core that the autoscaling framework (or other plugins) can use.
> It is much cleaner and simpler to do it once in Solr.
Not in Solr-core, though. If user chooses to not use autoscaling framework,
there should be absolutely no footprint of such a coordination layer for that
user.
##########
File path:
solr/core/src/java/org/apache/solr/cluster/events/ClusterSingleton.java
##########
@@ -0,0 +1,14 @@
+package org.apache.solr.cluster.events;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+/**
+ * Intended for {@link org.apache.solr.core.CoreContainer} plugins that should
be
+ * enabled only one instance per cluster.
+ * <p>Implementation detail: currently these plugins are instantiated on the
+ * Overseer leader, and closed when the current node loses its leadership.</p>
+ */
+@Retention(RetentionPolicy.RUNTIME)
+public @interface ClusterSingleton {
Review comment:
This level of service can be provided to plugins, but this doesn't need
to be in solr-core. This coordination can be a separate plugin outside
solr-core that the autoscaling framework (or other plugins) can use.
> It is much cleaner and simpler to do it once in Solr.
Not in Solr-core, though. If user chooses to not use autoscaling framework,
there should be absolutely no footprint of such a coordination layer for that
user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
