ErickErickson opened a new pull request #1796:
URL: https://github.com/apache/lucene-solr/pull/1796


   This PR is just a starting point. I grepped through the source code to try 
to find all the references to "ant". Do you have any idea how many words in our 
code have "ant" in them? Like constant, spanTerm, .... ;) Over 7,000 if you're 
curious.
   
   Anyway, I pared all those down and there are  a few files (23 or so) that 
reference ant legitimately. I fixed some that were simple, things like how to 
run a particular test, but for a number of them I just added //nocommit so we 
can find them easily. Here are some examples of things I punted on and just 
added //nocommits for:
   
   - The lucene/benchmarks.
   - UnicodeProps.java references an "ant unicode-data" target.
   - TokebnInfoDictionaryTest has a reference to an "ant test-tools" target
   etc.
   
   I'll check against the 8x version for the targets I didn't immediately see a 
corresponding Gradle task for, and if the are missing on ant I'll feel safe to 
remove them. Also I haven't poked around (yet) in the gradle build for tasks 
that weren't named the same but did the same thing.
   
   I'll start working on some of the nocommits, any hints welcome. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to