noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683778043
Let us take a step back and reassess at what we have today. https://github.com/apache/lucene-solr/blob/4a2a2da462ef017154856edd92b9f4f8c549c084/solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java#L385 There is already an interface called `AssignStrategy` .Can you believe that it's as simple as ` public interface AssignStrategy {` ` List<ReplicaPosition> assign(SolrCloudManager solrCloudManager, AssignRequest assignRequest)` `throws Assign.AssignmentException, IOException, InterruptedException;` ` }` This is simple interface is doing the trick today (there are 3 different impls using this interface). We are proposing to introduce a few dozen classes and interfaces to improve upon this. In reality, I do not see anybody other than a couple of Solr devs actually using this new framework. This is going to be a huge ball and chain. We will be struggling to deprecate this an year down the line. Let's not do this My suggestion is to not build anything new . Just use this interface ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
