[
https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187798#comment-17187798
]
Jason Gerlowski commented on SOLR-14677:
----------------------------------------
No, this bug fix was very recent - well after the plugin was split out. I
opened a PR for the plugin
[here|https://github.com/rohitbemax/dataimporthandler/pull/7], but can't merge
it because I don't have write access. [~ichattopadhyaya] mentioned being
willing to help review in Slack, but he may have gotten busy. Hopefully someone
is able to merge it in.
> DIH doesnt close DataSource when import encounters errors
> ---------------------------------------------------------
>
> Key: SOLR-14677
> URL: https://issues.apache.org/jira/browse/SOLR-14677
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 7.5, master (9.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Attachments: error-solr.log, no-error-solr.log
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> DIH imports don't close DataSource's (which can hold db connections, etc.) in
> all cases. Specifically, if an import runs into an unexpected error
> forwarding processed docs to other nodes, it will neglect to close the
> DataSource's when it finishes.
> This problem goes back to at least 7.5. This is partially mitigated in older
> versions of some DataSource implementations (e.g. JdbcDataSource) by means of
> a "finalize" hook which invokes "close()" when the DataSource object is
> garbage-collected. In practice, this means that resources might be held open
> longer than necessary but will be closed within a few seconds or minutes by
> GC. This only helps JdbcDataSource though - all other DataSource impl's risk
> leaking resources.
> In master/9.0, which requires a minimum of Java 11 and doesn't have the
> finalize-hook, the connections are never cleaned up when an error is
> encountered during DIH. DIH will likely be removed for the 9.0 release, but
> if it isn't this bug should be fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
